-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support for "redis.user" setting when authenticating to the Redis cache #2666
Conversation
Passing run #314 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportBase: 86.39% // Head: 86.40% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2666 +/- ##
=======================================
Coverage 86.39% 86.40%
=======================================
Files 289 289
Lines 15993 16003 +10
Branches 2017 2018 +1
=======================================
+ Hits 13817 13827 +10
Misses 1788 1788
Partials 388 388
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
When I configure my local Redis to enforce a username/password with an ACL, here's an example error I get:
This tells me that I've clearly enabled the ACL correctly locally. Just doing a few more tests here but this feels good to go... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments here - this got away from me a bit, but it should be good now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NevilleS
Closes #2665
Code Changes
username
argtestpassword
Steps to Confirm
I used my local Docker setup to test the following configs:
redis.password
norredis.user
) connectsredis.password
does not connectredis.password
andredis.user
does not connectredis-server --requirepass <password>
):redis.password
and noredis.user
connectsredis.password
and incorrectredis.user
does not connectredis.password
does not connectredis.password
norredis.user
) does not connectredis-server <path/to/redis.conf>
):redis.password
andredis.user
connectsredis.password
norredis.user
) does not connectredis.password
andredis.user
does not connectFor testing the Redis server with an ACL, I created this file at
./docker/redis/redis.conf
:I then modified
docker-compose.yml
to configure theredis
service as:And updated the
.fides/fides.toml
settings like:Pre-Merge Checklist
CHANGELOG.md